Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add new grpc conn settings #169

Merged
merged 5 commits into from
Jan 10, 2024
Merged

chore: add new grpc conn settings #169

merged 5 commits into from
Jan 10, 2024

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps requested a review from erka January 10, 2024 01:28
@markphelps markphelps requested a review from a team as a code owner January 10, 2024 01:28
@markphelps markphelps mentioned this pull request Jan 10, 2024
Closed
1 task
erka
erka approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great.

One thing I suggest to have grpc_conn_max_age instead of conn_max_age.

configuration/overview.mdx Outdated Show resolved Hide resolved
@markphelps markphelps enabled auto-merge (squash) January 10, 2024 12:37
@markphelps markphelps merged commit 2285401 into main Jan 10, 2024
1 check passed
@markphelps markphelps deleted the grpc-conn-docs branch January 10, 2024 12:39
markphelps added a commit that referenced this pull request Jan 10, 2024
@markphelps
Merge branch 'main' into jwt-docs
cfc7b48 
* main:
  chore: add new grpc conn settings (#169)
  feat: add gcp docs (#168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

@erka erka erka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markphelps @erka @GeorgeMac